Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use paddle.cast instead of Tensor.astype #9461

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Nov 20, 2024

PR types

Others

PR changes

APIs

Description

相关PR:https://github.com/PaddlePaddle/Paddle/pull/69333/files#diff-0865d6eede2e320c86708a3faf581051af9087e731d64d9b38abcfb48ac694abR102-R103

暂时调用paddle.cast代替astype,避免因为dtype相同而跳过cast计算导致模型报错,等分布式修复后再改回去

use paddle.cast instead of Tensor.astype
Copy link

paddle-bot bot commented Nov 20, 2024

Thanks for your contribution!

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (872aafa) to head (a6d5e4b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/gpt/modeling_auto.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9461      +/-   ##
===========================================
- Coverage    53.00%   52.77%   -0.24%     
===========================================
  Files          680      679       -1     
  Lines       109563   108368    -1195     
===========================================
- Hits         58078    57188     -890     
+ Misses       51485    51180     -305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 2b8a77b into PaddlePaddle:develop Nov 21, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants