Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] Fix eval for map dataset #9472

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

DesmonDay
Copy link
Contributor

PR types

Others

PR changes

Others

Description

现有drop last逻辑会使得eval数据集为空,因此删除该逻辑。当数据不满一个batch_size时,这块逻辑已处理,因此可以正常运行。

Copy link

paddle-bot bot commented Nov 21, 2024

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.13%. Comparing base (6813e40) to head (37bec75).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9472      +/-   ##
===========================================
+ Coverage    52.91%   53.13%   +0.22%     
===========================================
  Files          679      685       +6     
  Lines       108433   109601    +1168     
===========================================
+ Hits         57378    58239     +861     
- Misses       51055    51362     +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DesmonDay DesmonDay merged commit 7bfe5bc into PaddlePaddle:develop Nov 22, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants