Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix pp eval shape bug #9505

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[BUG] fix pp eval shape bug #9505

merged 1 commit into from
Nov 27, 2024

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Nov 27, 2024

PR types

Bug fixes

PR changes

APIs

Description

修复pp eval的时候训练batch size跟eval batch size不一致导致的通信时候缓存的cache shape不一致的错误。
比如:训练的micro bs=2,评估的micro bs=1,此时,当训练到需要评估的时候(eval_batch),此时会使用训练的bs=2的缓存的shape,从而导致评估的时候报错。
image

Copy link

paddle-bot bot commented Nov 27, 2024

Thanks for your contribution!

@JunnYu JunnYu requested a review from ZHUI November 27, 2024 03:52
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lugimzzz
Copy link
Contributor

你这是修复了什么case下的报错?之前是发现只有打开enable_clear_every_step_cache会报错?

Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ZHUI ZHUI merged commit 8d8a42c into PaddlePaddle:develop Nov 27, 2024
9 of 12 checks passed
@JunnYu JunnYu deleted the fix_pp_eval branch November 28, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants