fix csrc readme #9515
Merged
fix csrc readme #9515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9515 +/- ##
===========================================
+ Coverage 52.87% 53.03% +0.15%
===========================================
Files 687 694 +7
Lines 109186 110190 +1004
===========================================
+ Hits 57727 58434 +707
- Misses 51459 51756 +297 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Nov 28, 2024
llm/predict/export_model.py
Outdated
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| import paddle | |||
| from paddle.distributed import fleet | |||
| from predict.predictor import ModelArgument, PredictorArgument, create_predictor | |||
| from llm.predict.predictor import ModelArgument, PredictorArgument, create_predictor | |||
There was a problem hiding this comment.
这里的话，这样就假定根目录是 PaddleNLP 不是 PaddleNLP/llm了。对大多数case 可能有问题。另外起pr改吧。
There was a problem hiding this comment.
是指CI上的单测吗？那根目录设置在那里改呢？
There was a problem hiding this comment.
因为一般根目录大家都会设为PaddleNLP
yuanlehome
force-pushed
the
fix_csrc_readme
branch
from
cb9fdcc to
47cfeb7
Compare
ZHUI
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Docs
Description
fix csrc readme