Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support call sft training with clone PaddleNLP #9516

Merged
merged 25 commits into from
Dec 3, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Nov 28, 2024

PR types

New features

PR changes

APIs

Description

Support call sft training with clone PaddleNLP

Copy link

paddle-bot bot commented Nov 28, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gongel
❌ ZHUI
You have signed the CLA already but the status is still pending? Let us recheck it.

lugimzzz
lugimzzz previously approved these changes Nov 28, 2024
Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 37.36264% with 114 lines in your changes missing coverage. Please review.

Project coverage is 53.06%. Comparing base (5926c30) to head (d52ffe7).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trl/sft_trainer.py 39.66% 73 Missing ⚠️
paddlenlp/trl/extras/dataset_formatting.py 21.15% 41 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9516      +/-   ##
===========================================
+ Coverage    52.85%   53.06%   +0.21%     
===========================================
  Files          699      701       +2     
  Lines       110348   110591     +243     
===========================================
+ Hits         58321    58684     +363     
+ Misses       52027    51907     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 4d0fd0b into PaddlePaddle:develop Dec 3, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants