Fix paddle.where #9652
Merged
Fix paddle.where #9652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9652 +/- ##
===========================================
- Coverage 52.81% 52.81% -0.01%
===========================================
Files 710 710
Lines 111238 111241 +3
===========================================
Hits 58749 58749
- Misses 52489 52492 +3 ☔ View full report in Codecov by Sentry. |
DrownFish19
reviewed
Dec 18, 2024
| expanded_attn_mask = paddle.where(expanded_attn_mask.cast("bool"), x, y).astype(dtype) | ||
| elif get_env_device() == "xpu": | ||
| x = paddle.to_tensor(0.0, dtype="float32") | ||
| y = paddle.to_tensor(-1.7005809656952787e38, dtype="float32") |
There was a problem hiding this comment.
这里默认fp32吗？结束之后缺少.astype(dtype)，是否结果一致？
There was a problem hiding this comment.
是的，xpu的fa算子需要输入mask为fp32数据类型
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Models
Description
Force condition of
padlde.whereto be a boolean tensor.