Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] Fix loading rng state #9656

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[Trainer] Fix loading rng state #9656

merged 1 commit into from
Dec 19, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Hybrid paralell rng states changed when training environment differs, so we dot not set state tracker here.

Copy link

paddle-bot bot commented Dec 18, 2024

Thanks for your contribution!

@DesmonDay DesmonDay changed the title [Trainer] Update trainer.py [Trainer] Fix loading rng state Dec 18, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.80%. Comparing base (90bc68e) to head (bc86896).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9656      +/-   ##
===========================================
+ Coverage    52.21%   52.80%   +0.59%     
===========================================
  Files          721      718       -3     
  Lines       114885   112228    -2657     
===========================================
- Hits         59990    59267     -723     
+ Misses       54895    52961    -1934     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI merged commit 49d762f into develop Dec 19, 2024
11 of 14 checks passed
@ZHUI ZHUI deleted the DesmonDay-patch-5 branch December 19, 2024 06:19
blacksheep-Aristotle pushed a commit to blacksheep-Aristotle/PaddleNLP that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants