-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trainer] update sequence parallel #9757
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9757 +/- ##
===========================================
- Coverage 52.70% 52.37% -0.33%
===========================================
Files 731 727 -4
Lines 117313 115155 -2158
===========================================
- Hits 61827 60310 -1517
+ Misses 55486 54845 -641 ☔ View full report in Codecov by Sentry. |
1a21cd5
to
934a757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* update emb doc * update register_sequence_parallel_allreduce_hooks * update fuse_sequence_parallel_allreduce
* [Trainer] update sequence parallel (#9757) * update emb doc * update register_sequence_parallel_allreduce_hooks * update fuse_sequence_parallel_allreduce * fix matryoshka
PR types
Function optimization
PR changes
Others
Description
When use pipeline parallel and sequence parallel simultaneously, we should turn off partial send recv.