Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openocr IGTR method #14709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add openocr IGTR method #14709

wants to merge 2 commits into from

Conversation

Topdu
Copy link
Collaborator

@Topdu Topdu commented Feb 18, 2025

And fix parseq and ppstruct bug

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Feb 18, 2025

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Topdu Topdu requested review from SWHL, GreatV and an1018 and removed request for GreatV and SWHL February 18, 2025 09:44
@GreatV
Copy link
Collaborator

GreatV commented Feb 18, 2025

We need to sign the CLA again, the previous one is no longer valid.

SWHL
SWHL reviewed Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@SWHL SWHL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GreatV
GreatV reviewed Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding: Unit tests for new components, more detailed code comments in key implementation files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreatV GreatV GreatV left review comments

@SWHL SWHL SWHL left review comments

@an1018 an1018 Awaiting requested review from an1018

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Topdu @CLAassistant @GreatV @SWHL