Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[opcode][3.11] support closure #372

Merged
merged 33 commits into from
Sep 24, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Sep 4, 2023

改动:

  • 新增字节码MAKE_CELLCOPY_FREE_VARS
  • LOAD_CLOSURELOAD_DEREFSTORE_DEREF 行为变动适配

单测变化如下:

  • test_19_closure.py ❌ -> ✅
  • test_tensor_dtype_in_guard.py ❌ -> ✅

至此全部 SOT 单测已经通过 🎉~

本 PR 依赖于 PaddlePaddle/Paddle#57490PaddlePaddle/Paddle#57653

@paddle-bot
Copy link

paddle-bot bot commented Sep 4, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added the contributor External developers label Sep 4, 2023
@SigureMo SigureMo marked this pull request as ready for review September 21, 2023 02:05
@SigureMo SigureMo requested a review from zrr1999 September 21, 2023 14:59
SigureMo
SigureMo previously approved these changes Sep 21, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

zrr1999
zrr1999 previously approved these changes Sep 21, 2023
@SigureMo SigureMo dismissed stale reviews from zrr1999 and themself via c0ae3ce September 22, 2023 12:35
zrr1999
zrr1999 previously approved these changes Sep 23, 2023
Copy link
Member

@zrr1999 zrr1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 4974b06 into PaddlePaddle:develop Sep 24, 2023
@SigureMo SigureMo deleted the support_closure_py311 branch September 24, 2023 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants