Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formula and refine err hint #362

Merged

Conversation

HydrogenSulfate
Copy link
Collaborator

PR types

Others

PR changes

APIs

Describe

  1. 修复 LinearElasticity 公式粗体问题
  2. 完善 mesh 缺少包的报错信息

@HydrogenSulfate HydrogenSulfate changed the base branch from release/1.0 to develop June 5, 2023 13:20
@paddle-bot
Copy link

paddle-bot bot commented Jun 5, 2023

Thanks for your contribution!

@@ -133,7 +133,7 @@ def translate(self, translation, relative=True):
faces = np.array(self.faces)

if not checker.dynamic_import_to_globals(("open3d", "pymesh")):
raise ModuleNotFoundError
raise ModuleNotFoundError("Please install pymesh first.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果open3d没安装的话,是否需要提示?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 71dad3e into PaddlePaddle:develop Jun 6, 2023
@HydrogenSulfate HydrogenSulfate deleted the fix_liear_form branch June 6, 2023 05:36
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* fix LinearElasticity formula

* refine information of ModuleNotFoundError

* test=document_fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants