-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formula and refine err hint #362
Fix formula and refine err hint #362
Conversation
Thanks for your contribution! |
2504d1b
to
4e9172d
Compare
ppsci/geometry/mesh.py
Outdated
@@ -133,7 +133,7 @@ def translate(self, translation, relative=True): | |||
faces = np.array(self.faces) | |||
|
|||
if not checker.dynamic_import_to_globals(("open3d", "pymesh")): | |||
raise ModuleNotFoundError | |||
raise ModuleNotFoundError("Please install pymesh first.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果open3d没安装的话,是否需要提示?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
638feef
to
3889094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix LinearElasticity formula * refine information of ModuleNotFoundError * test=document_fix
PR types
Others
PR changes
APIs
Describe
LinearElasticity
公式粗体问题