add unit test for biharmonic #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
HydrogenSulfate
requested changes
Jun 20, 2023
There was a problem hiding this comment.
单测应该写的不正确，biharmonic是四阶微分，但是单测的参考值构造只用了一次hessian，相当于只有二阶微分
HydrogenSulfate
requested changes
Jun 23, 2023
test/equation/test_biharmonic.py
Outdated
Comment on lines
50
to
57
| # compute fourth order derivative | ||
| for var_i in (x, y): | ||
| for var_j in (x, y): | ||
| expected_result += hessian(hessian(u, var_i), var_j) | ||
| if dim == 3: | ||
| for var_i in (x, y, z): | ||
| for var_j in (x, y, z): | ||
| expected_result += hessian(hessian(u, var_i), var_j) |
There was a problem hiding this comment.
dim=3的时候，51-53行代码也会被执行，然后又执行了55-57行，这样显然是不对的，改成下面这样
# compute expected result
expected_result = -q / D
vars = (x, y)
if dim == 3:
vars += (z, )
for var_i in vars:
for var_j in vars:
expected_result += hessian(hessian(u, var_i), var_j)
Signed-off-by: jjyaoao <jjyaoao@126.com>
huohuohuohuohuo123
pushed a commit
to huohuohuohuohuo123/PaddleScience
that referenced
this pull request
Aug 12, 2024
add unit test for biharmonic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
add unit test for
biharmonic