Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for poisson #395

Closed
wants to merge 8 commits into from
Closed

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jun 19, 2023

PR types

Others

PR changes

Others

Describe

#378 3.6 poisson
add unit test for poisson

result:

aistudio@jupyter-115720-6409174:~/PaddleScience$ pytest --cov=./ppsci/equation/pde test/equation/test_poisson.py
========================================================================= test session starts ==========================================================================
platform linux -- Python 3.8.8, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /home/aistudio/PaddleScience
plugins: anyio-3.7.0, cov-4.1.0
collected 2 items                                                                                                                                                      

test/equation/test_poisson.py ..                                                                                                                                 [100%]

----------- coverage: platform linux, python 3.8.8-final-0 -----------
Name                                      Stmts   Miss  Cover
-------------------------------------------------------------
ppsci/equation/pde/__init__.py                9      0   100%
ppsci/equation/pde/base.py                   26      6    77%
ppsci/equation/pde/biharmonic.py             17     13    24%
ppsci/equation/pde/laplace.py                15     11    27%
ppsci/equation/pde/linear_elasticity.py     155    149     4%
ppsci/equation/pde/navier_stokes.py          60     53    12%
ppsci/equation/pde/normal_dot_vec.py         13      9    31%
ppsci/equation/pde/poisson.py                13      0   100%
ppsci/equation/pde/viv.py                    20     13    35%
-------------------------------------------------------------
TOTAL                                       328    254    23%


========================================================================== 2 passed in 3.86s ===========================================================================

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


enkilee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot
Copy link

paddle-bot bot commented Jun 19, 2023

Thanks for your contribution!

test/equation/test_poisson.py Outdated Show resolved Hide resolved
test/equation/test_poisson.py Outdated Show resolved Hide resolved
test/equation/test_poisson.py Outdated Show resolved Hide resolved
@HydrogenSulfate
Copy link
Collaborator

另外在修改完之后,请贴上单测覆盖率达到100%的截图

@HydrogenSulfate
Copy link
Collaborator

提交代码之前请先在 PaddleScience 目录下安装 pre-commit

pip install pre-commit
pre-commit install

@enkilee
Copy link
Contributor Author

enkilee commented Jun 19, 2023

提交代码之前请先在 PaddleScience 目录下安装 pre-commit

pip install pre-commit
pre-commit install

收到,我看了错误才发现要和PP一样装pre-commit,抱歉

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate
Copy link
Collaborator

license/cla 好像卡住了,可以执行一下 git commit --allow-empty --amend,补一个空commit 再PR一下,重新触发cla认证

@enkilee
Copy link
Contributor Author

enkilee commented Jun 19, 2023

收到

@enkilee
Copy link
Contributor Author

enkilee commented Jun 19, 2023

搞不懂为什么cla一直不过,我重新提个试试看吧

@HydrogenSulfate
Copy link
Collaborator

搞不懂为什么cla一直不过,我重新提个试试看吧

image
看起来没有签署成功

@enkilee
Copy link
Contributor Author

enkilee commented Jun 19, 2023

签了,签了N次。。。

@enkilee
Copy link
Contributor Author

enkilee commented Jun 19, 2023

@HydrogenSulfate 佬,PR 400 cla成功,这个就不合入了啊。抱歉,麻烦您了

@HydrogenSulfate
Copy link
Collaborator

same as #400 , closed this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants