Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

为 PaddleScience 的 equation 模块添加单元测试 test_navier_stokes #414

Merged
merged 10 commits into from
Jul 10, 2023
Merged

为 PaddleScience 的 equation 模块添加单元测试 test_navier_stokes #414

merged 10 commits into from
Jul 10, 2023

Conversation

mrcangye
Copy link
Contributor

@mrcangye mrcangye commented Jul 2, 2023

PR types

New features

PR changes

APIs

Describe

#378

@paddle-bot
Copy link

paddle-bot bot commented Jul 2, 2023

Thanks for your contribution!

@mrcangye mrcangye changed the title addleScience 的 equation 模块添加单元测试 test_navier_stokes PaddleScience 的 equation 模块添加单元测试 test_navier_stokes Jul 2, 2023
@mrcangye mrcangye changed the title PaddleScience 的 equation 模块添加单元测试 test_navier_stokes 为 PaddleScience 的 equation 模块添加单元测试 test_navier_stokes Jul 2, 2023
@mrcangye
Copy link
Contributor Author

mrcangye commented Jul 2, 2023 •
edited
Loading

还在修改中.....小哥等我！！！

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 3, 2023
@luotao1 luotao1 mentioned this pull request Jun 23, 2023
Closed
@luotao1
Copy link
Collaborator

luotao1 commented Jul 7, 2023

顺便解决下 CodeStyle 流水线的问题

@mrcangye
Copy link
Contributor Author

mrcangye commented Jul 8, 2023

顺便解决下 CodeStyle 流水线的问题

好嘞

HydrogenSulfate
HydrogenSulfate requested changes Jul 8, 2023
View reviewed changes
test/equation/test_navier_stokes.py Outdated Show resolved Hide resolved
test/equation/test_navier_stokes.py Outdated Show resolved Hide resolved
test/equation/test_navier_stokes.py Outdated Show resolved Hide resolved
HydrogenSulfate
HydrogenSulfate requested changes Jul 8, 2023
View reviewed changes
test/equation/test_navier_stokes.py Outdated Show resolved Hide resolved
test/equation/test_navier_stokes.py Outdated Show resolved Hide resolved
test/equation/test_navier_stokes.py Outdated Show resolved Hide resolved
test/equation/test_navier_stokes.py Outdated Show resolved Hide resolved
test/equation/test_navier_stokes.py Show resolved Hide resolved
@mrcangye mrcangye requested a review from HydrogenSulfate July 9, 2023 06:38
HydrogenSulfate
HydrogenSulfate approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 512c1c8 into PaddlePaddle:develop Jul 10, 2023
@mrcangye
Copy link
Contributor Author

LGTM

谢谢小哥的耐心教导！！！比心~

huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
@mrcangye
为 PaddleScience 的 equation 模块添加单元测试 test_navier_stokes (PaddlePaddle#414
4b97180 
)

* add test_navier_stokes.py

* rewrite test/equation/test_navier_stokes.py

* rewrite test_navier_stokes.py

* rewrite test_navier_stokes.py

* write test_navier_stokes.py

* fix some problem

* fix some problem

* rewrite test_navier_stokes.py

* fix problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HydrogenSulfate HydrogenSulfate HydrogenSulfate approved these changes

Assignees

@luotao1 luotao1

@HydrogenSulfate HydrogenSulfate

Labels
contributor HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrcangye @luotao1 @HydrogenSulfate