Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【hydra No.9】darcy2d #590

Merged
merged 9 commits into from
Oct 27, 2023
Merged

【hydra No.9】darcy2d #590

merged 9 commits into from
Oct 27, 2023

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Oct 22, 2023

PR types

Others

PR changes

Others

Describe

#571

9 darcy2d

@paddle-bot
Copy link

paddle-bot bot commented Oct 22, 2023

Thanks for your contribution!

@co63oc
Copy link
Contributor Author

co63oc commented Oct 22, 2023

CI中按原参数测试会有错误
image

@luotao1 luotao1 mentioned this pull request Oct 23, 2023
Closed
HydrogenSulfate
HydrogenSulfate requested changes Oct 26, 2023
View reviewed changes
examples/darcy/conf/darcy2d.yaml Outdated Show resolved Hide resolved
examples/darcy/conf/darcy2d.yaml Show resolved Hide resolved
examples/darcy/conf/darcy2d.yaml Outdated Show resolved Hide resolved
examples/darcy/darcy2d.py Outdated Show resolved Hide resolved
docs/zh/examples/darcy2d.md Outdated Show resolved Hide resolved
HydrogenSulfate
HydrogenSulfate requested changes Oct 26, 2023
View reviewed changes
examples/darcy/darcy2d.py Outdated Show resolved Hide resolved
examples/darcy/darcy2d.py Outdated Show resolved Hide resolved
co63oc and others added 3 commits October 26, 2023 19:29
@co63oc @HydrogenSulfate
Apply suggestions from code review
083c25a 
Co-authored-by: HydrogenSulfate <490868991@qq.com>
@co63oc
Fix
2a072a0
@co63oc
Fix
b022d5f
@HydrogenSulfate HydrogenSulfate added the HappyOpenSource 快乐开源活动issue与PR label Oct 27, 2023
HydrogenSulfate
HydrogenSulfate requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦修改之后顺便合入一下最新develop分支，里面解决了CI挂掉的问题

docs/zh/examples/darcy2d.md Outdated Show resolved Hide resolved
docs/zh/examples/darcy2d.md Outdated Show resolved Hide resolved
@co63oc
Copy link
Contributor Author

co63oc commented Oct 27, 2023

已合并develop分支

@co63oc
Copy link
Contributor Author

co63oc commented Oct 27, 2023

image
CI错误提示是tools目录
代码没有tools目录
image

HydrogenSulfate
HydrogenSulfate approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 0b1607d into PaddlePaddle:develop Oct 27, 2023
1 check passed
@co63oc co63oc deleted the darcy2d branch October 31, 2023 06:50
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
@co63oc @HydrogenSulfate
【hydra No.9】darcy2d (PaddlePaddle#590)
688e315 
* Add darcy2d hydra

* Fix

* Fix

* Fix

* Apply suggestions from code review

Co-authored-by: HydrogenSulfate <490868991@qq.com>

* Fix

* Fix

* Fix

---------

Co-authored-by: HydrogenSulfate <490868991@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HydrogenSulfate HydrogenSulfate HydrogenSulfate approved these changes

Assignees

@luotao1 luotao1

@HydrogenSulfate HydrogenSulfate

Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@co63oc @HydrogenSulfate @luotao1