Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refine] Refine yinglong code #786

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

HydrogenSulfate
Copy link
Collaborator

PR types

Others

PR changes

APIs

Describe

  1. Yinglong 推理类代码从 base.Predictor 继承
  2. 推理参数改为 yaml 控制

[pull] develop from PaddlePaddle:develop
[pull] develop from PaddlePaddle:develop
Copy link

paddle-bot bot commented Feb 23, 2024

Thanks for your contribution!

# YingLong-12 Layers
python examples/yinglong/predict_12layers.py
python ./predict_12layers.py mode=infer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要这个“./”吧?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

# YingLong-24 Layers
# python examples/yinglong/predict_24layers.py
python ./predict_24layers.py mode=infer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

)
# predictor = YingLong(
# args.model_file, args.params_file, args.mean_path, args.std_path
# )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的代码可以删掉啦

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

subdir: ./

# general settings
mode: train # running mode: train/eval
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mode默认值可以改成infer,默认值为目前还不支持的train有点奇怪

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改为infer

Copy link
Collaborator

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 2a8a8c4 into PaddlePaddle:develop Feb 23, 2024
3 of 4 checks passed
@HydrogenSulfate HydrogenSulfate deleted the refine_yinglong branch February 23, 2024 11:18
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* refine yinglong predictor and use config instead of argparser

* modify README of yinglong

* fix for review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants