Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scipy import error #3874

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix scipy import error #3874

merged 1 commit into from
Nov 11, 2024
+1 −1

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 6, 2024

PR types

Bug fixes

PR changes

Others

Describe

This pull request includes a small change to the paddlespeech/t2s/modules/pqmf.py file. The change modifies the import statement to use scipy.signal.windows instead of scipy.signal for the kaiser function.

@mergify mergify bot added the T2S label Nov 6, 2024
@zxcd
Copy link
Collaborator

zxcd commented Nov 8, 2024

这个问题是否与scipy的版本有关？

@GreatV
Copy link
Contributor Author

GreatV commented Nov 8, 2024

@zxcd scipy 1.0以后这个就变了

zxcd
zxcd approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxcd zxcd merged commit 21b5541 into PaddlePaddle:develop Nov 11, 2024
5 checks passed
@GreatV GreatV deleted the fix_scipy_import_error branch November 11, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxcd zxcd zxcd approved these changes

Assignees
No one assigned
Labels
contributor T2S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreatV @zxcd