[Hackathon 7th] fix example led_en_zh st1 #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
This pull request includes changes to improve the handling of JSON data and logging within the
examples/ted_en_zh/st1/local/data.shandutils/addjson.pyfiles. The most important changes include updating the JSON data formatting script and modifying the logging mechanism.Improvements to JSON data handling:
examples/ted_en_zh/st1/local/data.sh: Added a missing backslash to properly format the JSON data by ensuring the command continues on the next line.Codebase simplification and logging improvements:
utils/addjson.py: Removed the import ofget_commandline_argsfromespnet.utils.cli_utilsas it was no longer used.utils/addjson.py: Updated the logging to useargsinstead ofget_commandline_args()to streamline the logging process.