Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PaddlePaddle Hackathon] 第37题 AlphaDropout单测 #232

Merged
merged 18 commits into from
Oct 22, 2021
Merged

[PaddlePaddle Hackathon] 第37题 AlphaDropout单测 #232

merged 18 commits into from
Oct 22, 2021

Conversation

iverxin
Copy link
Contributor

@iverxin iverxin commented Oct 11, 2021

PR types

Others

PR changes

Others

Describe

Task: #35968

  1. 增加AlphaDropout的单元测试文件
  2. 重写父类的run_base函数，确保动态图和静态图的测试时产生的随机数相同

@iverxin
Copy link
Contributor Author

iverxin commented Oct 13, 2021

  1. 在测试子类中重写了_base_run, run等函数，以确保动态图和静态图生成的随机mask一致

@iverxin iverxin mentioned this pull request Oct 14, 2021
Closed
kolinwei
kolinwei requested changes Oct 14, 2021
View reviewed changes
framework/api/nn/test_alpha_dropout.py
def test_alpha_dropout1():
"""
default
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc中写明测试点，验证的内容，

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已添加~

@iverxin iverxin requested a review from kolinwei October 18, 2021 02:55
@iverxin iverxin requested a review from kolinwei October 19, 2021 07:56
@iverxin
Copy link
Contributor Author

iverxin commented Oct 21, 2021

请问什么时候可以merge呢~

@DDDivano DDDivano merged commit c9cb9da into PaddlePaddle:develop Oct 22, 2021
@iverxin iverxin deleted the t37_2 branch October 27, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolinwei kolinwei kolinwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iverxin @kolinwei @DDDivano