add try call to enhance robust of server #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Superjomn
commented
Jan 14, 2018
•
Superjomn
commented
- when server encounters some error, it will sleep for some time and retry later.
…ce/server_revisit
…DL-1 into enhance/server_revisit
jacquesqiao
reviewed
Jan 14, 2018
| res = lib.retry(error_retry_times, function, error_sleep_time, *args, | ||
| **kwargs) | ||
| if not res: | ||
| raise exceptions.IOError("server IO error, will retry latter.") |
There was a problem hiding this comment.
这个抛一个异常没啥用了吧，直接返回一个error_code和error msg？
There was a problem hiding this comment.
前台会处理500，直接抛500
status code前台现在没有统一的机制来处理
jacquesqiao
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.