Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify image sample usage #139

Merged
merged 1 commit into from
Jan 15, 2018
Merged

simplify image sample usage #139

merged 1 commit into from
Jan 15, 2018

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jan 15, 2018 •
edited
Loading

add an add_sample interface, and use as follows:

image.add_sample(shape, image)

the original method is

idx = image.is_sample_taken()
if idx >= 0:
    image.set_sample(idx, shape, data)

jacquesqiao
jacquesqiao approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@Superjomn Superjomn merged commit 6f02954 into PaddlePaddle:develop Jan 15, 2018
@Superjomn Superjomn deleted the enhance/simplify_image branch January 15, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@daming-lu daming-lu Awaiting requested review from daming-lu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Superjomn @jacquesqiao