Binary Record Fixe #260
Merged
Binary Record Fixe #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerator method. std::hash is not consistent across OS. It will generate different hash's when ran on different OS on the same string. Change the filename generator to use a static counter. It will be more ideal to use UUID generator available in boost 1.4.2, however, boost 1.4.2 has problems compiling on c++11 \n* Fix issue with pytorch demo where it logs to the absolute path /workspace \n * Fix performance issue on server when server fails to load image file. Currently server retries an API call 3 times before it fails, at which point it'll sleep the thread for 2 secs. This becomes problematic when there are alot of SDK errors. I'll create seperate issue to refine the retry logic to not be so expensive on the server.
cs2be
requested review from
Superjomn,
varunarora,
nickyfantasy,
jetfuel,
jacquesqiao and
daming-lu
Superjomn
reviewed
Feb 6, 2018
visualdl/storage/binary_record.h
Outdated
| @@ -52,42 +51,59 @@ struct BinaryRecord { | |||
| file.write(data_.data(), data_.size()); | |||
| } | |||
|
|
|||
| const std::string& hash() { return hash_; } | |||
| static std::string generateFileName() { | |||
There was a problem hiding this comment.
GenerateFileName
according to https://google.github.io/styleguide/cppguide.html#Function_Names
visualdl/storage/binary_record.h
Outdated
| // which impacts performance. | ||
| if (!filename_.empty()) { | ||
| std::string path = dir_ + "/" + filename_; | ||
| std::cout << "READING FILE: " << path << std::endl; |
There was a problem hiding this comment.
remove this line, in the training period, cout with an endl is low performance.
There was a problem hiding this comment.
Ops sorry, forgot to remove this line, will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with binary_record.h filename generator method. std::hash is not consistent across OS. It will generate different hash's when ran on different OS on the same string. Change the filename generator to use a static counter. It will be more ideal to use UUID generator available in boost 1.4.2, however, boost 1.4.2 has problems compiling on c++11
Fix issue with pytorch demo where it logs to the absolute path /workspace
Fix performance issue on server when server fails to load image file. Currently server retries an API call 3 times before it fails, at which point it'll sleep the thread for 2 secs. This becomes problematic when there are alot of SDK errors. I'll create seperate issue to refine the retry logic to not be so expensive on the server.