Redesign chart toolbar icons and improve UX for download chart JSON data #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add new toolbar icons and reimplement functions instead of using Echart built in icons -Remove show data link option, instead add a collapse menu to select data download from each chart -Only show toolbar icons when hover over card
jetfuel
approved these changes
Mar 12, 2018
| loader: 'file-loader', | ||
| options: { | ||
| name: 'images/[name].[hash].[ext]' | ||
| name: 'assets/[name].[hash].[ext]' |
There was a problem hiding this comment.
Do we have any images left in the images directory?
| ></v-select> | ||
|
|
||
| <v-checkbox class="visual-dl-page-config-checkbox" label="Show data download links" v-model="config.downloadLink" dark></v-checkbox> |
There was a problem hiding this comment.
Why do we remove the checkbox? I think we should keep this checkbox so we don't always display the download buttons. Please let me know if the design changes
There was a problem hiding this comment.
Ya, the data buttons would now be collapsed within each chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add new toolbar icons and reimplement functions instead of using Echart built in icons
-Remove show data link option, instead add a collapse menu to select data download from each chart
-Only show toolbar icons when hover over card