Use ESlint to format the Javascript and Vue files. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strongly recommended rules applied.
daming-lu
previously approved these changes
Apr 5, 2018
nickyfantasy
previously approved these changes
Apr 5, 2018
nickyfantasy
reviewed
Apr 5, 2018
|
|
||
| export default { | ||
| name: 'App', | ||
| components: { | ||
| AppMenu | ||
| AppMenu, |
There was a problem hiding this comment.
im surprised the correct standard is to add comma in everything D:
daming-lu
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strongly recommended rules applied.
Hi guys. Here is the phrase 1 of ESLint PR to address #364
There are many files changed, but you really just need to check the following two.
frontend/.eslintrc.js - This is the ESLint config files
frontend/package.json - We need to install the package via npm
I haven't tried to link the eslint to pre-commit. I will create a follow up to include that. Also it will take some time to update all the code.
Meanwhile, if you wish to manually check the format. Use the following two commands