Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added edges to graph. Also added script to download mock models #39

Merged
merged 7 commits into from
Dec 28, 2017
Merged

Added edges to graph. Also added script to download mock models #39

merged 7 commits into from
Dec 28, 2017

Conversation

daming-lu
Copy link
Collaborator

Add edges to graph. For example, a node as following:

{
  "attribute":[
    {
      "ints":[
        "2",
        "2"
      ],
      "name":"strides",
      "type":"INTS"
    },
    {
      "ints":[
        "0",
        "0",
        "0",
        "0"
      ],
      "name":"pads",
      "type":"INTS"
    },
    {
      "ints":[
        "3",
        "3"
      ],
      "name":"kernel_shape",
      "type":"INTS"
    }
  ],
  "input":[
    "data_0",
    "conv1_w_0",
    "conv1_b_0"
  ],
  "name":"",
  "opType":"Conv",
  "output":[
    "conv1_1"
  ]
}

will have 4 edges:

[
{'source': u'data_0', 'target': 'node_0', 'label': 'label_0'}, 
{'source': u'conv1_w_0', 'target': 'node_0', 'label': 'label_1'}, 
{'source': u'conv1_b_0', 'target': 'node_0', 'label': 'label_2'}, 
{'source': 'node_0', 'target': u'conv1_1', 'label': 'label_3'}
]

Superjomn
Superjomn suggested changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Json files are too large.

server/visualdl/mock/squeezenet_graph.json Outdated
@@ -0,0 +1,2072 @@
{
"input": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this JSON file is too large, can we use a smaller model or just some pseudo-data?
just checking the logic do not need a full model.

If others need a complex JSON, give them offline seems more reasonable.

server/visualdl/mock/inception_graph.json Outdated
"name": "conv1/7x7_s2_w_0",
"shape": [
"64",
"3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too large JSON file.

jacquesqiao
jacquesqiao reviewed Dec 28, 2017
View reviewed changes
server/visualdl/mock/README.md
@@ -0,0 +1,8 @@
## Note
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add a download script

@daming-lu daming-lu changed the title Add edges to graph. Add squeezenet to mock data. Added edges to graph. Also added script to download mock models Dec 28, 2017
Superjomn
Superjomn approved these changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daming-lu daming-lu merged commit b079592 into develop Dec 28, 2017
@daming-lu daming-lu mentioned this pull request Dec 29, 2017
Closed
Superjomn pushed a commit to Superjomn/VisualDL-1 that referenced this pull request Dec 29, 2017
@jacquesqiao
format code with pre-commit (PaddlePaddle#39)
341a322
Superjomn pushed a commit to Superjomn/VisualDL-1 that referenced this pull request Dec 29, 2017
@daming-lu
Added edges to graph. Also added script to download mock models (Padd…
7aee3b6 
…lePaddle#39)

* Add edges to graph. Add squeezenet to mock data.

* rm json

* rm pb files and add links to them

* Add edges to graph. Add squeezenet to mock data.

rm json

rm pb files and add links to them

* added download script

* typo
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 12, 2018
@daming-lu
Added edges to graph. Also added script to download mock models (Padd…
58e7b58 
…lePaddle#39)

* Add edges to graph. Add squeezenet to mock data.

* rm json

* rm pb files and add links to them

* Add edges to graph. Add squeezenet to mock data.

rm json

rm pb files and add links to them

* added download script

* typo
jacquesqiao added a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
@jacquesqiao
format code with pre-commit (PaddlePaddle#39)
35fcbbc
@jacquesqiao jacquesqiao deleted the add_edge_to_graph_data branch January 13, 2018 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao left review comments

@Superjomn Superjomn Superjomn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daming-lu @Superjomn @jacquesqiao