Add travis test for graph edges #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daming-lu
commented
Jan 2, 2018
| @@ -29,6 +29,8 @@ def reorganize_inout(json_obj, key): | |||
|
|
|||
|
|
|||
| def add_edges(json_obj): | |||
| # TODO(daming-lu): should try to de-duplicate node's out-edge | |||
| # Currently it is counted twice: 1 as out-edge, 1 as in-edge | |||
There was a problem hiding this comment.
这个会根据前端的需要进行改进，先看看前端是怎么渲染的吧。
jacquesqiao
reviewed
Jan 2, 2018
tests.sh
Outdated
| sudo pip install google | ||
| sudo pip install protobuf | ||
| sudo apt-get install protobuf-compiler libprotoc-dev | ||
| sudo pip install onnx |
There was a problem hiding this comment.
不需要安装onnx，但是需要安装protobuf，而且最好指定一下版本，我用的3.1.0
jacquesqiao
reviewed
Jan 3, 2018
server/build.sh
Outdated
| ls $pb_file | ||
| echo '$$CORE_PATH' | ||
| else | ||
| echo 'no!!' |
There was a problem hiding this comment.
搞定，因为我们把protoc搞定了，所以不用这一步了。
Superjomn
reviewed
Jan 3, 2018
server/visualdl/graph_test.py
Outdated
| json_obj = json.loads(json_str) | ||
| # 286 edges + 143 nodes (out-edge of each node is counted twice) | ||
| self.assertEqual(len(json_obj['edges']), 286 + 143) | ||
|
|
There was a problem hiding this comment.
check several nodes whether they are marked as the right type.
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 12, 2018
* Add test for graph edges * add new line * add google protobuf * add onnx to travis * install protoc and move installs to tests.sh * tune protoc * try to install onnx * onnx always fails on travis, try script from onnx github * install protobuf 3.1.0 but not onnx * in the right dir * tune path * should work * put onnx_pb2 there and it should work * what if remove onnx_pb2.py * cp compiled onnx_pb2 to the right place * debug * protoc * install protoc * chown * test * added protc, should work * typo * does it exist? * hmmmm * try dropbox * test 1 * now it should work * done * make tests more thorough
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 13, 2018
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 13, 2018
* Add test for graph edges * add new line * add google protobuf * add onnx to travis * install protoc and move installs to tests.sh * tune protoc * try to install onnx * onnx always fails on travis, try script from onnx github * install protobuf 3.1.0 but not onnx * in the right dir * tune path * should work * put onnx_pb2 there and it should work * what if remove onnx_pb2.py * cp compiled onnx_pb2 to the right place * debug * protoc * install protoc * chown * test * added protc, should work * typo * does it exist? * hmmmm * try dropbox * test 1 * now it should work * done * make tests more thorough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.