support inputs as list and add some OPs support #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeliang2258
changed the title
yeliang2258
changed the title
jiangjiajun
requested changes
Jan 5, 2022
| shape=[1], | ||
| fill_value=-1) | ||
| self.paddle_graph.add_layer( | ||
| "paddle.multiply", |
There was a problem hiding this comment.
paddle.neg是paddle 2.2之后才有的API，新增了一个判断，2.2之后使用paddle.neg，否则还是-1来乘。
jiangjiajun
reviewed
Jan 7, 2022
| data = weights.pop(origin_name) | ||
| else: | ||
| data = weights[origin_name] | ||
| data = weights[origin_name] |
There was a problem hiding this comment.
一个权重可能和多个算子相关，不能一个算子之后直接将权重pop出来
There was a problem hiding this comment.
如若不删除这个weights，会有什么影响，是否会导致转换后的inference模型更大
jiangjiajun
approved these changes
Jan 11, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create A Good Pull Request
Please check the follow step before merging this pull request
If this PR add new model support, please update
model_zoo.mdand add model to out test model zoos(@wjj19950828)