This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix SRL training #413
Merged
Fix SRL training #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
commented
Sep 15, 2017
| @@ -211,6 +214,7 @@ def event_handler(event): | |||
| output_layer=predict, | |||
| parameters=parameters, | |||
| input=test_data, | |||
| feeding=feeding, | |||
There was a problem hiding this comment.
The bug is here. The feeding should be set.
reyoung
commented
Sep 15, 2017
| @@ -178,7 +181,7 @@ def event_handler(event): | |||
| print "Pass %d, Batch %d, Cost %f, %s" % ( | |||
| event.pass_id, event.batch_id, event.cost, event.metrics) | |||
| if event.batch_id % 1000 == 0: | |||
| result = trainer.test(reader=reader, feeding=feeding) | |||
| result = trainer.test(reader=test_reader, feeding=feeding) | |||
There was a problem hiding this comment.
This is another bug but not related to issue.
train_reader and test_reader should be two instances because test will read all data in reader. If they are the same instance, training data will be reset every time.
dzhwinter
approved these changes
Sep 15, 2017
| @@ -211,6 +214,7 @@ def event_handler(event): | |||
| output_layer=predict, | |||
| parameters=parameters, | |||
| input=test_data, | |||
| feeding=feeding, | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #374