Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Paddle Toolkit Development Competition No.5】 Paddle 适配 torch_harmonics #1004

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

lixiaoming233
Copy link
Contributor

【赛题5 RFC】 Paddle 适配 torch_harmonics

Copy link

paddle-bot bot commented Nov 5, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交PR,有一个建议可以看一下


其中基于 pytorch 的API在 Paddle 中绝大多数都有对应或通过组合替代的方式实现。

但是在 'torch_harmonics.examples.sfno' 这个包中所导入的 'tensorly' 库与 'tltorch' 只支持 pytorch 框架下使用,暂未实现 paddle 的适配工作,因此暂时不对这个 example 进行适配。
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. tensorly 的paddle后端已经支持(PR),
    image
    作者可能比较忙没有发布whl,所以需要通过源码安装方式安装main分支即可
  2. 可以看下具体调用了tltorch里的哪些接口,是否可以使用 tensorly 里的接口组合实现?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢指正。
sfno中主要调用了tltorch.FactorizedTensor,正在尝试组合替代

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢指正。 sfno中主要调用了tltorch.FactorizedTensor,正在尝试组合替代

看起来是有这个接口的:https://github.com/search?q=repo%3Atensorly%2Ftensorly%20FactorizedTensor&type=code

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM

@HydrogenSulfate HydrogenSulfate merged commit 00db12b into PaddlePaddle:master Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants