【Hackathon No.17】RFC #144
Merged
【Hackathon No.17】RFC #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoooo0820
reviewed
May 31, 2022
| * x1和x2：输入的两个tensor | ||
| * target：真实的类别标签 | ||
| * input1和input2：输入的两个tensor | ||
| * label：真实的类别标签 |
There was a problem hiding this comment.
再加一行name的说明吧。另外下面的工作也需要同步做一下：
- API添加name参数，注意也将name参数传入函数内部调用的部分其他API，细节可参考其他loss函数的实现
- 中/英文文档补充name参数及对应说明
zoooo0820
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原本RFC在：#52
修改了部分参数名