Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.12】add RFC for pairwise_distance API #165

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

Ainavo
Copy link
Contributor

@Ainavo Ainavo commented Jul 6, 2022

为 paddle 新增 pairwise_distance API

* rfc:pairwise_distance

* v0.1.1:格式修改

* 丰富了Paddle现状

* Update rfcs/APIs/20220705_api_design_for_pairwise_distance.md

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>

* v 0.1.2

* v 0.1.3

* v 1.0.4

* v 1.0.5

* v1.0.0

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2022

CLA assistant check
All committers have signed the CLA.

iclementine
iclementine previously approved these changes Jul 7, 2022
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
很细致的调研。

关于 PairewiseDistance 目前不能处理 x 和 y 都是 1d tensor 的情况,可以尝试修改一下使之支持。

@Ainavo
Copy link
Contributor Author

Ainavo commented Jul 7, 2022

好的,已将该情况的具体修改方案补充上去了

@iclementine iclementine merged commit 7fa5f9b into PaddlePaddle:master Jul 7, 2022
@SigureMo SigureMo deleted the rfc_for_pairwise_distance branch July 7, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants