【Hackathon No.5】为 Paddle 新增 bucketize #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Li-fAngyU
changed the title
jeff41404
reviewed
Jul 11, 2022
| # 六、测试和验收的考量 | ||
| 测试考虑的case如下： | ||
|
|
||
| - 和pytorch结果的数值的一致性, `paddle.bucketize`,和`torch.bucketize`结果是否一致； |
There was a problem hiding this comment.
unit test can only use numpy
|
Done! |
jeff41404
reviewed
Jul 14, 2022
| - 未输入`right`时的输出正确性； | ||
| - 未输入`out_int32`时的输出正确性； | ||
| - 错误检查：输入`x`不是Tensor时,能否正确抛出错误； | ||
| - 错误检查：`axis`所指维度在当前Tensor中不合法时能正确抛出错误。 |
There was a problem hiding this comment.
there is no parameter of axis, why do we need this case
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaddlePaddle Hackathon 第三期 No.5 为 Paddle 新增 bucketize