-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon No.77】为神经网络编译器 CINN 增加 squeeze 算子 #182
Conversation
嗨,你好,对设计文档,建议补充:
|
好的,我已经按照要求优化了一下文档 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
总体没有什么问题了,请注意我comment的细节问题
|
||
## 1、相关背景 | ||
|
||
`squeeze` 是众多神经网络编译器中基础的算子,FQ, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FQ在这里是什么意思?是否可以删除?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的已修改
## 底层OP设计 | ||
|
||
1. 在 `cinn/hlir/pe/transform.cc` 里实现 `squeeze` 算子。 | ||
2. 在 `cinn/hlir/op/transform.h` 里声明相应的 `strategy`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CINN最近会迁移新的IR schedule
。所以我们未来会把旧的schedule
放在cinn/hlir/pe/
下,而新的compute和schedule都放在cinn/hlir/op
下,所以麻烦更改算子的实现路径。更多信息可以到时直播贡献代码指南时讲解。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,后面我观看直播学习
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.