Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.30】 #28

Closed
wants to merge 1 commit into from
Closed

【Hackathon No.30】 #28

wants to merge 1 commit into from

Conversation

gsq7474741
Copy link
Contributor

为 Paddle 新增 TripletMarginWithDistanceLoss 损失函数API rfc

@gsq7474741
Copy link
Contributor Author

@TCChenlong

@dingjiaweiww
Copy link
Contributor

你的 PR 提交成功，感谢你对于开源项目的贡献，请检查 PR 提交格式和内容是否完备，具体请参考示例和模版。

@dingjiaweiww
Copy link
Contributor

PR 格式检查通过，你的PR 将接受Paddle 专家以及开源社区的review，请及时关注PR 动态

shiyutang
shiyutang requested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@shiyutang shiyutang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体格式和上一个PR存在同样问题，故不再赘述，可以参考上一个PR中review意见：https://github.com/PaddlePaddle/community/pull/27/files

@paddle-bot-old
Copy link

你的PR有最新反馈，请及时修改。
There’s the latest feedback about your PR. Please check.

@dingjiaweiww dingjiaweiww mentioned this pull request Mar 23, 2022
Closed
@TCChenlong
Copy link
Contributor

#34 merged, this PR is closed, thanks for your contribution!

@TCChenlong TCChenlong closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyutang shiyutang shiyutang requested changes

Assignees

@DDDivano DDDivano

@shiyutang shiyutang

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gsq7474741 @dingjiaweiww @TCChenlong @shiyutang @DDDivano @yang131313