Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackthon 4 No.14】Add Polar #364

Merged
merged 7 commits into from
Feb 27, 2023
Merged

【Hackthon 4 No.14】Add Polar #364

merged 7 commits into from
Feb 27, 2023

Conversation

PommesPeter
Copy link
Contributor

added paddle.polar rfc doc.

@paddle-bot
Copy link

paddle-bot bot commented Feb 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@PommesPeter PommesPeter changed the title Polar Add Polar Feb 21, 2023
iclementine
iclementine reviewed Feb 21, 2023
View reviewed changes
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for polar

@PommesPeter
Copy link
Contributor Author

PommesPeter commented Feb 21, 2023 •
edited
Loading

sorry, bucketize is an unused doc. I will delete it.

iclementine
iclementine requested changes Feb 21, 2023
View reviewed changes
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scipy 和 tf 的 polar 语义和此次提及的 polar 不一致，建议修改文档

rfcs/APIs/20230221_api_design_for_polor.md Outdated Show resolved Hide resolved
@PommesPeter PommesPeter changed the title Add Polar 【Hackthon 4 No.14】Add Polar Feb 21, 2023
@PommesPeter PommesPeter mentioned this pull request Feb 26, 2023
Closed
@luotao1 luotao1 merged commit 249ef34 into PaddlePaddle:master Feb 27, 2023
@luotao1 luotao1 mentioned this pull request Feb 28, 2023
Closed
@Ligoml Ligoml mentioned this pull request Mar 7, 2023
Closed
@PommesPeter PommesPeter mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclementine iclementine iclementine approved these changes

Assignees

@luotao1 luotao1

@iclementine iclementine

@cloud2009 cloud2009

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PommesPeter @iclementine @luotao1 @cloud2009