-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RFC of introducing ruff
#412
Conversation
## 七、排期规划 | ||
|
||
- NumPy-specific rules(NPY001) | ||
- pyupgrade(UP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
由于 Ruff 自开始开发以来时间还不长,因此使用 Ruff 的项目还不多,但目前正在高速增长着,在 GitHub 上已经拥有 9.5k Star,在 Python 社区非常受欢迎。目前 Ruff 已经被 pandas、Transformers (Hugging Face)、Diffusers (Hugging Face)、SciPy、Jupyter、Pylint 等知名项目所使用。 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I observed that Ruff is in the high-speed iterative development stage. The latest version at the beginning of March 2023 is 0.0.254. If we start to use it now, we also need to pay attention to updating the version several times in the future weeks or months until it is stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯嗯对的,不过在锁版本的前提下 Ruff 本身的提示、修复效果足够稳定,目前在 Paddle 的实验还没有发现误检测的情况,如果遇到相关情况也是可以通过禁用这条 rule 来确保对代码库无影响。
关于更新版本的成本,我认为偶尔更新即可(比如一个月),不需要频繁更新,因此不需要付出太多的维护成本。
相关链接:作者关于 stable 版本的回复 astral-sh/ruff#1992 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. In the chapter 7 scheduling plan, we need to add a plan description for future updates, e.g. three updates expected this year(Jun, Sep, Dec), or updates by version, v0.1.0 update once, v0.2.0 update again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
引入 Ruff 的 RFC~