【Hackathon 4th No.13】为 Paddle 新增 Bernoulli API #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cxxly
reviewed
Mar 16, 2023
| ## 命名与参数设计 | ||
| - 类名: `Bernoulli` | ||
| - API: `class paddle.distribution.Bernoulli(probs=None, logits=None)` | ||
|
|
There was a problem hiding this comment.
目前因为其它API没有支持logits，为了保持一致，前期仅支持probs就行；如果有兴趣，可以所有API统一支持logits
There was a problem hiding this comment.
OK! 那我这里修改为
class paddle.distribution.Bernoulli(probs)有机会的话尝试把其他分布也写一下～ ：）
cxxly
reviewed
Mar 16, 2023
| 不涉及 | ||
|
|
||
| ## API实现方案 | ||
| ### 继承父类: [Distribution](https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/distribution/distribution.py#L33) |
There was a problem hiding this comment.
这里确实犹豫过是继承 Distribution 还是 ExponentialFamily，
PyTorch 中 Bernoulli 和 Normal 都是用的 ExponentialFamily，而 paddle 的 Normal 继承的是 Distribution，所以这里遵从了 paddle 的习惯。
那我这里改一下，
### 继承父类: [ExponentialFamily]：）
There was a problem hiding this comment.
OK！我尽量多参考现有的方案～
谢谢！：）
cxxly
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Docs
Describe
[used AI Studio]