【Hackathon No.27】为 Paddle 新增 frac 数学计算API #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。 |
luotao1
reviewed
Mar 21, 2022
|
|
||
| ## 命名与参数设计 | ||
|
|
||
| API设计为`paddle.frac(x, name=None)`和tensor.frac(x, name=None) |
Collaborator
There was a problem hiding this comment.
Tensor.frac(x, name=None)
|
|
||
| # 二、飞桨现状 | ||
|
|
||
| 飞浆目前并无此API，具体实现可由`trunc`和`elementwise_sub`组合实现。 |
Collaborator
There was a problem hiding this comment.
- 笔误：飞桨
- 具体实现可由
trunc和elementwise_sub组合实现。是在python端调这两个的C++ OP呢，还是直接用这两个python组合呢？如果后者的话，接口是paddle.subtract，也可以直接用-。
Contributor
Author
There was a problem hiding this comment.
调用了C++OP，elementwise_sub调用的是_elementwise_op与_elementwise_op_in_dygraph
Collaborator
There was a problem hiding this comment.
好的，那可以明确说一下是在python端调用C++ Op实现。
|
|
||
| ## API实现方案 | ||
|
|
||
| 使用`trunc`与`elementwise_sub`组合实现，实现位置为`paddle/tensor/math.py`与`sum`,`nansum`等方法放在一起： |
|
你的PR有最新反馈，请及时修改。 |
Contributor
Author
|
已修改完毕 |
DDDivano
approved these changes
Mar 24, 2022
|
你的PR已合入community库，请进行后续代码开发，并将代码提交至Paddle仓库。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 Paddle 新增 frac 数学计算API