【Hackathon 5th No.26】 为 Paddle 新增 diagonal_scatter API #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxcd
reviewed
Oct 7, 2023
| - `src` 为 tensor类型，用于填充input。 | ||
| - `offset` int类型,可选,决定是哪一个对角线,默认为0。 | ||
| - `dim1` int类型,可选,第一个维度来考虑对角线,默认为0。 | ||
| - `dim1` int类型,可选,第而个维度来考虑对角线,默认为1。 |
zxcd
reviewed
Oct 7, 2023
| Tensor.diagonal_scatter | ||
|
|
||
| ```python | ||
| Tensor.diagonal_scatter(x, offset=0, dim1=0, dim2=1, name=None) |
There was a problem hiding this comment.
Tensor.diagonal_scatter(y, offset=0, dim1=0, dim2=1, name=None)?
zxcd
reviewed
Oct 7, 2023
| # 六、测试和验收的考量 | ||
| 参考：[新增API 测试及验收规范](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/api_contributing_guides/api_accpetance_criteria_cn.html) | ||
|
|
||
| 可考虑一下场景： |
zxcd
reviewed
Oct 7, 2023
|
|
||
| ## API实现方案 | ||
|
|
||
| 参考MindSpore的方式去是实现对应的代码 |
There was a problem hiding this comment.
写出具体实现位置，如python/paddle/tensor/manipulation.py
zxcd
reviewed
Oct 7, 2023
|
|
||
| ## 3、意义 | ||
|
|
||
| 为 Paddle 新增 `paddle.diagonal_scatter` API，丰富Paddle的Tensor相关API，支持更多样的tensor操作 |
There was a problem hiding this comment.
和Tensor.diagonal_scatter，另外统一大小写
|
已经有 RFC 合入了，如果需要更新和完善，可以在原来的 RFC 上进行修改，感谢！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.