Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack5 38 kernel v2.1 #798

Merged
merged 7 commits into from
Jan 15, 2024
Merged

Hack5 38 kernel v2.1 #798

merged 7 commits into from
Jan 15, 2024

Conversation

megemini
Copy link
Contributor

PR types

New features

PR changes

Docs

Description

  • 修改 RFC 中函数签名
  • 补充参数说明

@Charles-hit @jeff41404

请评审 ~

Copy link

paddle-bot bot commented Jan 12, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

Copy link

@Charles-hit Charles-hit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个地方需要修改一下:
1.由于 fractional max poolingadaptive max pooling 接口特性较为相似,后续设计方案以 共用 adaptive max pooling 底层算子 为主要设计思路。
这儿是单独实现op
2.yaml中op名字以及infermeta名字需要修改

@megemini
Copy link
Contributor Author

Update 20240115

  • 修改 rfc 中实现方案的描述为 单独实现算子
  • 修改 yaml 及 infer meta 相关内容
  • 修改方案实现中的函数签名
  • 修改 markdow 格式

@Charles-hit 请评审 ~

@megemini megemini requested a review from Charles-hit January 15, 2024 07:59
@luotao1 luotao1 merged commit 66b0838 into PaddlePaddle:master Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants