【Hackathon No.1&No.2】为 Paddle 新增 finfo API和iinfo API #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
isLinXu
changed the title
isLinXu
changed the title
|
开发者你好，pr格式需要调整，请参考：
|
|
1.添加API-iinfo |
Ligoml
changed the title
|
PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。 |
cxxly
reviewed
Apr 8, 2022
cxxly
reviewed
Apr 8, 2022
cxxly
reviewed
Apr 8, 2022
| # 五、设计思路与实现方案 | ||
|
|
||
| ## 命名与参数设计 | ||
| 参考：[飞桨API 设计及命名规范](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/api_contributing_guides/api_design_guidelines_standard_cn.html) |
cxxly
reviewed
Apr 8, 2022
cxxly
reviewed
Apr 8, 2022
cxxly
reviewed
Apr 8, 2022
| is_floating_point: _bool | ||
| is_complex: _bool | ||
| is_signed: _bool | ||
| ... |
There was a problem hiding this comment.
这个类的作用是？paddle dtype可以参考 https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/framework/dtype.py
cxxly
reviewed
Apr 8, 2022
cxxly
reviewed
Apr 8, 2022
|
|
||
| # 六、测试和验收的考量 | ||
|
|
||
| 参考：[新增API 测试及验收规范](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/api_contributing_guides/api_accpetance_criteria_cn.html) |
cxxly
reviewed
Apr 8, 2022
cxxly
reviewed
Apr 8, 2022
|
你的PR有最新反馈，请及时修改。 |
|
看到PR中多了一个文件，旧的文件rfcs/APIs/20220330_api-design_for_finfo.md 可以删除掉。 |
cxxly
reviewed
Apr 11, 2022
|
已根据老师的建议进行相应的修改，麻烦老师确认和指点 |
|
已根据API的RFC新增代码至对应位置，辛苦审核老师检查，有问题指出来 |
|
您好，请问代码PR是否提交了 @isLinXu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.添加API-iinfo
ISSUE：PaddlePaddle/Paddle#40333
2.添加API-finfo
ISSUE：PaddlePaddle/Paddle#40334