【Hackathon 7th No.20】为 Paddle 新增 Tensor.set_ / Tensor.resize_ API #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxcd
reviewed
Sep 29, 2024
| 测试case： | ||
|
|
||
| paddle.Tensor.set_ | ||
| - 正确性验证：可以与 as_strided 的结果对齐； |
There was a problem hiding this comment.
此处要关注as_strided仅动态图支持，set_是否能同时支持动静态图
There was a problem hiding this comment.
set_按这样设计只支持动态图，目前是否有支持静态图的inplace API?
There was a problem hiding this comment.
inplace API 只支持动态图没有问题，但需要加上@inplace_apis_in_dygraph_only 的 tag。表明该API仅支持动态图
| - old_size > new_size ； | ||
| - 验证不同dtype类型：`bfloat16`，`float16`，`float32`，`float64`，`bool`，`int8`，`int16`，`int32`，`int64`，`uint8`，`complex64`，`complex128`； | ||
| - 验证不同计算设备：覆盖 CPU 和 GPU 等实现； | ||
|
|
| const std::vector<int64_t>& stride, | ||
| int64_t offset, | ||
| DenseTensor* out) { | ||
| AsStridedKernel<Context>(dev_ctx, source, dims, stride, offset, out); |
There was a problem hiding this comment.
如与as_strided 类似，是否还需要新增kernel？
There was a problem hiding this comment.
因为 set_ 的参数比 as_strided 多了一个 source tensor，如果把 AsStridedKernel 改为 inplace，然后传入 source 的shape/stride/offset，
return _C_ops.as_strided_(x, shape, stride, offset)这样没法做到让 x 和 source 共享 holder_，也就是 x._is_shared_buffer_with(source) 会返回 false
|
|
||
| ## 2、功能目标 | ||
| - 实现 paddle.Tensor.set_ 做为 Tensor 的方法使用。设置 Tensor 与 source 共享相同的存储空间，且可设置为与 source 相同或不同的 shape，stride，offset。 | ||
| - 实现 paddle.Tensor.resize_ 做为 Tensor 的方法使用。重新调整 Tensor 的 size，若新 numel 小于等于原 numel，不改变存储空间大小；若新 numel 大于原 numel，需调整存储空间大小。 |
There was a problem hiding this comment.
这个存储空间是指 storage 接口返回的数组，paddle 对应的应该是 holder_ 这个 Tensor 的内部属性吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.