Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCM] add is_compiled_with_rocm api, test=develop #3526

Merged
merged 4 commits into from
May 31, 2021
Merged

[ROCM] add is_compiled_with_rocm api, test=develop #3526

merged 4 commits into from
May 31, 2021

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented May 21, 2021 •
edited
Loading

@paddle-bot-old
Copy link

Thanks for your contribution!

@qili93 qili93 mentioned this pull request May 21, 2021
Merged
@qili93 qili93 mentioned this pull request May 25, 2021
Merged
@qili93 qili93 requested a review from TCChenlong May 27, 2021 03:33
TCChenlong
TCChenlong reviewed May 27, 2021
View reviewed changes
docs/api/paddle/is_compiled_with_rocm_cn.rst Outdated

返回：支持GPU(ROCm)则为True，否则为False。

返回：是否支持GPU(ROCm)的bool值
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13、15 写成一行吧，
返回：bool，支持GPU(ROCm)则为True，否则为False。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/api/paddle/is_compiled_with_rocm_cn.rst Outdated
@@ -0,0 +1,24 @@
.. _cn_api_fluid_is_compiled_with_rocm:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_cn_api_fluid_is_compiled_with_rocm -> _cn_api_paddle_is_compiled_with_rocm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

TCChenlong
TCChenlong approved these changes May 27, 2021
View reviewed changes
Copy link
Collaborator

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 110d5b9 into PaddlePaddle:develop May 31, 2021
@qili93 qili93 deleted the add_rocm_api branch May 31, 2021 08:57
@qili93 qili93 mentioned this pull request Jun 1, 2021
Merged
qili93 added a commit that referenced this pull request Jun 9, 2021
@qili93
[ROCM] add is_compiled_with_rocm api, test=develop (#3526) (#3551)
c5b0594 
* [ROCM] add is_compiled_with_rocm api, test=develop

* [ROCM] update api doc, test=develop

* [ROCM] address review comment, test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qili93 @TCChenlong