Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix paddle.vision.datasets.* cn docs #4944
fix paddle.vision.datasets.* cn docs #4944
Changes from 7 commits
9804ea3
142ad6d
9d3e6bd
7296f46
ec0d866
c311919
274f18d
0fc40a9
637f323
9558f83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
属性部分请参考规范
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
刚刚看了一下,但关于属性我有很大的疑问,这个属性如果中文文档这么写的话,英文文档要往哪里写呢?因为属性是不同于方法没有一个地方写 docstring 的呀(应该是这样子的吧)?
我看了下示例的 paddle.static.Program(paddle.Program 没有找到,貌似是 API 改名了?),我发现文档里暴露的属性都是
@property
装饰(或者说 getter)后的属性,这些属性确实是可以写 docstring,但相应的,非@property
装饰的属性要如何写 docstring 呢?而且这个 API 文档里貌似有点混乱,属性里混入了大量的方法唔,我又翻看了一些其他的类,貌似并没有找到相关可以参考的内容(非
@property
装饰的暴露的属性且中英文文档都完善的)~所以说属性的话是不管英文文档嘛?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TCChenlong 呼唤龙哥,这个标准怎么说?