data type extension of operators #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xreki
reviewed
Jul 7, 2022
| @@ -0,0 +1,108 @@ | |||
| # 算子数据类型扩展 验收规范 | |||
|
|
|||
| ## CI通过性 | |||
|
|
||
| 提交至 Paddle repo 的 Pull Request（简称 PR），涉及到的相关检测CI必须全部 Pass。用来验证对之前功能点的兼容和影响，保障新合入代码对历史代码不产生影响。 | ||
|
|
||
| 新增代码必须要有相应的单测保障测试覆盖率达到准入要求（测试覆盖率（行覆盖率)90%）。 |
There was a problem hiding this comment.
改为 （行覆盖率达到90%）
| 扩展数据类型后需要添加对应数据类型的单元测试，并通过算子的精度检查。单元测试需要注意以下规范： | ||
| - [OP单测必须使用大尺寸输入](https://github.com/PaddlePaddle/Paddle/wiki/OP-test-input-shape-requirements) | ||
| - [反向Op必须调用check_grad](https://github.com/PaddlePaddle/Paddle/wiki/Gradient-Check-Is-Required-for-Op-Test) | ||
| - [单测精度中atol, rtol, eps, max_relative_error, 不允许自行放大阈值](https://github.com/PaddlePaddle/Paddle/wiki/OP-test-accuracy-requirements) |
There was a problem hiding this comment.
fp16可以给出建议的atol、rtol设置，因为默认的atol、rtol是针对fp64的
There was a problem hiding this comment.
单测框架中check_out只提供了绝对误差atol的设置，默认是1e-5，允许用户修改这个值不是合理，例如下面的例子，实际第一个元素误差已经很大，allclose的绝对误差默认设置是1e-8，都能通过检查。
a = np.array([1.234678e-7, 5.8902198e-10])
b = np.array([1.244678e-7, 5.8902198e-10])
np.allclose(a,b) # True
check_grad的接口提供了max_relative_error设置，默认是0.005，这个相对误差容忍度感觉已经偏高了。
在单测规范中也说明了如有特殊需求，需要特定人员审核。应该由开发者给出验证结论后，再评估是否允许设置。
docs/dev_guides/op_dtype_extension/op_dtype_extension_acceptance_criteria_cn.md
Outdated
Show resolved
Hide resolved
zhangting2020
force-pushed
the
op_opt
branch
3 times, most recently
from
673ca82
to
3f020e7
Compare
zhangting2020
force-pushed
the
op_opt
branch
2 times, most recently
from
f6e15a3
to
39a23a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data type extension of operators