Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyperlink in Chinese Overview doc #5307

Merged
merged 4 commits into from
Oct 8, 2022

Conversation

caolonghao
Copy link
Contributor

@caolonghao caolonghao commented Sep 26, 2022

中文概述处
提PR来修复一个bug
以及
提PR来实现一个新功能
的超链接会跳转至使用指南,使用逻辑上容易造成疑惑和混乱。将这两处的超链接修改为文档中PR指南的链接
https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html
更符合中文使用逻辑

fixes #5308

@paddle-bot
Copy link

paddle-bot bot commented Sep 26, 2022

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5307.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:[Beta]飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2022

CLA assistant check
All committers have signed the CLA.

@SigureMo
Copy link
Member

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? > Let us recheck it.

需要签署下 CLA~

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@caolonghao
Copy link
Contributor Author

嘿嘿,感谢回复

@SigureMo SigureMo requested a review from Ligoml September 29, 2022 06:54
Copy link
Collaborator

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为贡献文档做了更新,所以这两个链接跳转到:https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html
会更合适,还需要cherry-pick到release2.4rc
另外建议单独修改一下release2.3的跳转链接到:https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html

注意使用相对路径,方便版本管理~ @caolonghao

@caolonghao
Copy link
Contributor Author

@Ligoml

因为贡献文档做了更新,所以这两个链接跳转到:https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html 会更合适,还需要cherry-pick到release2.4rc 另外建议单独修改一下release2.3的跳转链接到:https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html

注意使用相对路径,方便版本管理~ @caolonghao

对Github的使用不算特别熟悉,这里的意思是指在develop分支下将跳转链接修改为https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html
并提交到 develop 分支,然后cherry-pick对应commit到release2.4分支吗?这之后再切换到 release2.3 分支修改为
https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html 并push?

@SigureMo
Copy link
Member

SigureMo commented Oct 8, 2022

@Ligoml

因为贡献文档做了更新,所以这两个链接跳转到:paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html 会更合适,还需要cherry-pick到release2.4rc 另外建议单独修改一下release2.3的跳转链接到:paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html
注意使用相对路径,方便版本管理~ @caolonghao

对Github的使用不算特别熟悉,这里的意思是指在develop分支下将跳转链接修改为paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html 并提交到 develop 分支,然后cherry-pick对应commit到release2.4分支吗?这之后再切换到 release2.3 分支修改为 paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html 并push?

对滴,release/2.4 可以等本 PR merge 后直接从 develop cherry-pick,release/2.3 直接手动修改即可

@caolonghao
Copy link
Contributor Author

明白了,感谢回复~

- [提 PR 来修复一个 bug](https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html)
- [提 PR 来实现一个新功能](https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html)
- [提 PR 来修复一个 bug](https://paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html)
- [提 PR 来实现一个新功能](https://paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意使用相对路径,方便版本管理~

这个还不是相对路径,相对路径才能保证直接 cherry-pick 到 release/2.4 也是正确的~

# 从
https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/Overview_cn.html
# 到
https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html
# 相对路径应该是
./code_contributing_path_cn.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okok,原来相对路径说的是这里啊,了解了

Copy link
Collaborator

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!LGTM

@Ligoml Ligoml merged commit 46f904d into PaddlePaddle:develop Oct 8, 2022
caolonghao added a commit to caolonghao/PaddleDocs that referenced this pull request Oct 9, 2022
* update hyperlinks for two PR related subjects

* Update hyperlinks for two PR related subjects

* Update links to relative path
jzhang533 pushed a commit that referenced this pull request Oct 9, 2022
update hyperlinks for two PR related subjects
@caolonghao caolonghao deleted the update-hyperlink branch October 10, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

中文概述处超链接指向容易引起困惑
4 participants