-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hyperlink in Chinese Overview doc #5307
Conversation
感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5307.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
需要签署下 CLA~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
嘿嘿,感谢回复 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为贡献文档做了更新,所以这两个链接跳转到:https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html
会更合适,还需要cherry-pick到release2.4rc
另外建议单独修改一下release2.3的跳转链接到:https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html
注意使用相对路径,方便版本管理~ @caolonghao
对Github的使用不算特别熟悉,这里的意思是指在develop分支下将跳转链接修改为https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html |
对滴,release/2.4 可以等本 PR merge 后直接从 develop cherry-pick,release/2.3 直接手动修改即可 |
明白了,感谢回复~ |
docs/dev_guides/Overview_cn.md
Outdated
- [提 PR 来修复一个 bug](https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html) | ||
- [提 PR 来实现一个新功能](https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html) | ||
- [提 PR 来修复一个 bug](https://paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html) | ||
- [提 PR 来实现一个新功能](https://paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注意使用相对路径,方便版本管理~
这个还不是相对路径,相对路径才能保证直接 cherry-pick 到 release/2.4 也是正确的~
# 从
https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/Overview_cn.html
# 到
https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html
# 相对路径应该是
./code_contributing_path_cn.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okok,原来相对路径说的是这里啊,了解了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!LGTM
* update hyperlinks for two PR related subjects * Update hyperlinks for two PR related subjects * Update links to relative path
中文概述处
提PR来修复一个bug
以及
提PR来实现一个新功能
的超链接会跳转至使用指南,使用逻辑上容易造成疑惑和混乱。将这两处的超链接修改为文档中PR指南的链接
https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/git_guides/submit_pr_guide_cn.html
更符合中文使用逻辑
fixes #5308