-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tutorials]城市街景分割数据集下使用对抗网络Pix2Pix根据掩码生成街景 #5439
[Tutorials]城市街景分割数据集下使用对抗网络Pix2Pix根据掩码生成街景 #5439
Conversation
感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5439.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
"\n", | ||
"## 1. 简要介绍\n", | ||
"### 关于城市街景分割数据集下使用对抗网络Pix2Pix根据掩码生成街景\n", | ||
"本项目的目标是,根据分割的伪色彩图生成对应的街道场景。\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可以加一下展示效果图方便用户理解,类似 左 分割lable图像 右 生成街景
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved
"outputs": [], | ||
"source": [ | ||
"! wget https://paddleseg.bj.bcebos.com/dataset/cityscapes.tar\n", | ||
"! tar -xf cityscapes.tar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
! tar -xf cityscapes.tar 运行报错,改为 ! tar -xvf cityscapes.tar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aistudio运行无报错,麻烦请再确认一下。
}, | ||
"outputs": [], | ||
"source": [ | ||
"! wget https://paddleseg.bj.bcebos.com/dataset/cityscapes.tar\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下载数据集后只有分割图像,没有城市场景图像
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
城市场景图像在cityscapes/leftImg8bit,分割在cityscapes/gtFine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
经RD确认:
1、网络结构没问题
2、代码质量,无错误,无冗余,整体看起来整洁
3、运行无报错,一个训练完了可以达到图例效果,一个训练一半,看loss是收敛的
4、能否达到上线“官网-》文档-〉应用实践”的标准:这两个实例代码比较简单,但整体质量还可以,感觉可以合入
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- https://ai-studio-static-online.cdn.bcebos.com/0312d38398f5453f928b12b14bf794d9513a2bd554874c57890cda0cc3caa2e9,引用的这个图片,可以放到这个目录下面,维护起来。
- 关于GAN的简介部分,可以引用相关的论文,或其他的介绍。第一次在文中出现这样的专业词汇,至少要给出其全称是什么。(GAN、G、D).
关于Paddle的梯度反馈
,这部分要写的更详细一些,如,自动累加模式,要给第一次了解这个概念的人讲清楚。另外这里的backword
是typo。- 致谢部分挪到最后吧。
**什么?上面没看懂?不重要!往下看就行了!锐利的loss!锐利的更新!永远的两步走!**
,Tutorial就直接讲解就好了,不太需要类似这样浮夸的语言。- 用到一些术语的时候,注意一下大小写,如PaddleSeg,而不是paddleseg。
- 展示运行结果的时候,要设置正确的环境,输出的结果里不能有WARNING。
整体上,文字讲解,太过于口语化,严谨程度不够,尚未达到上线官网的质量。
更新了文档表述,图片已经上传。直接更新图片链接会在合入后无法访问,暂时没有在链接中更新。 |
@wangna11BD wangna11BD 请RD协助再re一下代码质量,用户重新修改了 |
LGTM |
建议,文字部分,主要描述任务、网络、参数设置等基本说明,其余口语用词可以删除。 |
|
|
changed |
Add an example with Pix2Pix and Cityscapes