Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][py27]Python2退场:清除文档中和Python2有关的命令 #5466

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

caolonghao
Copy link
Contributor

Related Links

Tracking Issue: PaddlePaddle/Paddle#46837

Python2退场:清除文档中和Python2有关的命令

文档中有示例性能分析报告中看起来是在Python2环境中生成的,应该没有必要修改?
https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/guides/performance_improving/analysis_tools/cpu_profiling_cn.html
image

@paddle-bot
Copy link

paddle-bot bot commented Nov 30, 2022

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5466.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:[Beta]飞桨文档预览工具

@caolonghao caolonghao changed the title Python2退场:清除文档中和Python2有关的命令 [CodeStyle][py27]Python2退场:清除文档中和Python2有关的命令 Nov 30, 2022
@SigureMo SigureMo self-requested a review November 30, 2022 13:00
@SigureMo SigureMo self-assigned this Nov 30, 2022
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档中有示例性能分析报告中看起来是在Python2环境中生成的,应该没有必要修改?

嗯嗯这里是不用修改的,这个等以后更新这部分文档的时候应该就可以自动更新了

@@ -87,8 +80,6 @@

- macOS 下安装 PaddlePaddle 后 import paddle.fluid 出现`Fatal Python error: PyThreadState_Get: no current thread running`错误

- For Python2.7.x (install by brew): 请使用`export LD_LIBRARY_PATH=/usr/local/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7 && export DYLD_LIBRARY_PATH=/usr/local/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7`
- For Python2.7.x (install by Python.org): 请使用`export LD_LIBRARY_PATH=/Library/Frameworks/Python.framework/Versions/2.7 && export DYLD_LIBRARY_PATH=/Library/Frameworks/Python.framework/Versions/2.7`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个会和 #5460 冲突,#5460 会将这个 FAQ 直接移除,因此这里可以恢复一下~上面的 CentOS6 那个不用恢复

英文文档同

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@@ -20,7 +20,6 @@ addons:
- git
- python
- python-pip
- python2.7-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该整个文件都可以删除,因为已经不用 Travis CI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件已经删除,麻烦 @luotao1 再确认下这个配置文件是不是已经不用了~

docs/install/FAQ_en.md Outdated Show resolved Hide resolved
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@luotao1 luotao1 merged commit 1db127f into PaddlePaddle:develop Dec 1, 2022
@caolonghao caolonghao deleted the remove_python2 branch December 1, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants