Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

整理文档中原位（inplace）操作相关 API #5469

Merged
merged 11 commits into from
Dec 26, 2022
Merged

整理文档中原位（inplace）操作相关 API #5469

merged 11 commits into from
Dec 26, 2022

Conversation

ZhangYuef
Copy link
Contributor

@ZhangYuef ZhangYuef commented Dec 1, 2022 •
edited
Loading

整理文档中原位（inplace）操作相关 API

对应：

@paddle-bot
Copy link

paddle-bot bot commented Dec 1, 2022

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-5469.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：[Beta]飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ZhangYuef ZhangYuef mentioned this pull request Dec 2, 2022
Closed
@Ligoml
Copy link
Collaborator

Ligoml commented Dec 5, 2022

good job！
可能还需要在单独的api文档中增加inplace的介绍，可以详见：https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/guides/beginner/tensor_cn.html#tensor-shape

image

如果觉得超链接不够直观，也可以考虑直接在api文档中增加inplace的介绍

@Ligoml
Copy link
Collaborator

Ligoml commented Dec 5, 2022

另外需要处理一下冲突~

@ZhangYuef
Copy link
Contributor Author

@Ligoml 要么我在每个单独的 API 文档最后加上一句话 “更多关于 inplace 操作介绍详见 [超链接xxx] “？

good job！ 可能还需要在单独的api文档中增加inplace的介绍，可以详见：https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/guides/beginner/tensor_cn.html#tensor-shape

image

如果觉得超链接不够直观，也可以考虑直接在api文档中增加inplace的介绍

@Ligoml
Copy link
Collaborator

Ligoml commented Dec 7, 2022 •
edited
Loading

@Ligoml 要么我在每个单独的 API 文档最后加上一句话 “更多关于 inplace 操作介绍详见 [超链接xxx] “？

我觉得可以

@ZhangYuef
Copy link
Contributor Author

@Ligoml 把介绍加入啦

Ligoml
Ligoml reviewed Dec 13, 2022
View reviewed changes
docs/api/paddle/add__cn.rst Outdated Show resolved Hide resolved
@Ligoml
Copy link
Collaborator

Ligoml commented Dec 15, 2022

@ZhangYuef 有一些小建议看下~

@ZhangYuef @Ligoml
Update docs/api/paddle/add__cn.rst
62ae455 
赞

Co-authored-by: Ligoml <39876205+Ligoml@users.noreply.github.com>
@Ligoml
Copy link
Collaborator

Ligoml commented Dec 23, 2022

啊我意思是说这些link都可以统一加上介绍

@ZhangYuef
Copy link
Contributor Author

啊我意思是说这些link都可以统一加上介绍

@Ligoml 重新修改啦

Ligoml
Ligoml approved these changes Dec 26, 2022
View reviewed changes
Copy link
Collaborator

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job！LGTM

@Ligoml Ligoml merged commit 7e6335f into PaddlePaddle:develop Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligoml Ligoml Ligoml approved these changes

Assignees
No one assigned
Labels
contributor status: proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhangYuef @CLAassistant @Ligoml