Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phi::DenseTensor] delete LoDTensor in Zh files #5486

Merged
merged 18 commits into from
Dec 29, 2022

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Dec 5, 2022

delete LoDTensor in Zh files

大部分LoDTensor发生在api/paddle/static/nn/目录下,并且这些文档如果删除LoDTensor,意味着文档从表意上的大幅度修改。

@paddle-bot
Copy link

paddle-bot bot commented Dec 5, 2022

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5486.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:[Beta]飞桨文档预览工具

@chenwhql
Copy link
Contributor

chenwhql commented Dec 6, 2022

delete LoDTensor in Zh files

大部分LoDTensor发生在api/paddle/static/nn/目录下,并且这些文档如果删除LoDTensor,意味着文档从表意上的大幅度修改。

按实际情况描述清楚即可,原先LoDTensor和Tensor是两个不同的类,现在这两个统一为一个类DenseTensor,为了兼容LoD,DenseTensor中仍然有LoD的成员,从这个角度能讲清楚就行,例如:

  • case1:文档中主要描述LoDTensor描述,将LoDTensor换为Tensor即可(可以认为Tensor中含有LoD成员)
  • case2:文档中说必须用LoDTensor,不能是Tensor,就将这样的描述删除,再将LoDTensor替换为Tensor,其他描述基本不变

或者看下这里具体是对什么case比较困惑,我们可以就具体case讨论一下

@Ligoml
Copy link
Collaborator

Ligoml commented Dec 29, 2022

@luotao1 请帮忙豁免一下CI,copy-from挂掉的几篇文档是因为fluid清理导致的,后续会由相关同学统一删除中文文档

@Ligoml Ligoml merged commit f856489 into PaddlePaddle:develop Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants